Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling the entry/exit action when transitioning to/from group state #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mtangy
Copy link

@mtangy mtangy commented Apr 10, 2019

Added capability to call the entry/exit action of a group state when transitioning to and from group states. This is consistent with other state machine frameworks (ex. QT state machine framework )

@misje
Copy link
Owner

misje commented Apr 15, 2019

Thanks for contributing, Michael! I will have a look shortly. It's been quite a while since I touched this code, so give me a chance to get back into the project. I just want to let you know that I am indeed going to look into your work. At a first glance: You are right, it does make sense to fire group actions. I guess I just never had this specific use case at the time I wrote this.

If you don't mind me asking: Are you currently using this framework for something? I'm asking because it'd be great to have unit tests, but I am not using this framework myself any more. If you have some test cases, be it actual unit tests or anything that would verify this new behaviour, I'd be very grateful! It's hard to judge whether people actually use this code or if it just somehow became popular, but in any case I'd prefer to not introduce (new) bugs. – And sadly I need to focus on other projects at the moment, so I don't have heaps of time at hand.

@mtangy
Copy link
Author

mtangy commented Apr 22, 2019

@misje Thanks for the response! I'm currently using the framework in an embedded application. I would greatly appreciate any feedback you have on the changes I made. I currently don't have any unit tests in place, however I do plan to create some in the near future and will share them as soon as I do.

@zhijackchen
Copy link

If it is multi-level FSM, the fix doesn't work. The fix only call current exit/entry and its parent exit/entry once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants