Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Skills associated to weapons #173

Closed
lozalojo opened this issue Oct 10, 2020 · 3 comments
Closed

[Bug] Skills associated to weapons #173

lozalojo opened this issue Oct 10, 2020 · 3 comments

Comments

@lozalojo
Copy link
Contributor

I create an Occupation with skill Fighting (Brawl).
If I add the Punch weapon (which uses Fighting (Brawl)) to the occupation, when creating the PC, the process ask me for the skill associated with Punch and allows me to enter again Brawl/Fighting, but base is 0.

I think it creates the skill as if it were new instead of using the one in the Skills compendium, I know it because I use icons for skills, and all the skills has the appropiate icon except the newly created Fighting (Brawl), which has the generic icon.

So better off without adding default weapons (in fact I only add "Unarmed" weapon).

Does this make sense to the process of adding skills to the character sheet?

@HavlockV
Copy link
Collaborator

When adding a weapon it tries to find a skill based on the name without the specialization. In that example the skill in the Weapon sheet should be named Brawl. If you name it Fighting (Brawl) it will not recognize it. After it is looking for skills in the character sheet not in the compendium.
I'll make the skill searching more aggressive, looking for closest match instead of exact match in the sheet first, then in compendium and if nothing found create a new one.
Items can be included in Setup, you can add the unarmed 'weapon' in it.

@lozalojo
Copy link
Contributor Author

Yes, that's what I've done. I have Unarmed created as a weapon in my weapon's compendium, its the way it should be handled, imho.

@HavlockV
Copy link
Collaborator

HavlockV commented Oct 13, 2020

weapons were created before skills.... hence, he couldn't find the skill for that weapon as it wasn't created yet.
It should be OK now, plus retrieving of the skill associated with a weapon has been hardened and is more aggressive.

@HavlockV HavlockV added the dev label Oct 13, 2020
@HavlockV HavlockV removed the 3.9 label Nov 9, 2020
@HavlockV HavlockV closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants