Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formula that uses git? #22

Closed
makew0rld opened this issue Dec 8, 2021 · 4 comments
Closed

Update formula that uses git? #22

makew0rld opened this issue Dec 8, 2021 · 4 comments

Comments

@makew0rld
Copy link

Would it be possible for this action to work with this kind of Formula?

Homebrew/homebrew-core#90700

See the original commit made by the action, and then the change made by me.

@makew0rld makew0rld changed the title Using git? Update formulat that uses git? Dec 8, 2021
@mislav
Copy link
Owner

mislav commented Dec 8, 2021

Yes it can: set the download-url in your workflow configuration to https://github.com/makeworld-the-better-one/amfora.git instead of to the tarball. This action will then update the tag and revision fields 👍 See the README for more information.

@mislav mislav closed this as completed Dec 8, 2021
makew0rld added a commit to makew0rld/amfora that referenced this issue Dec 8, 2021
@makew0rld makew0rld changed the title Update formulat that uses git? Update formula that uses git? Dec 8, 2021
@makew0rld
Copy link
Author

@mislav I tried that and still had issues, do you know why?

My config file:

on:
  push:
    tags:
      - "v*"

jobs:
  homebrew:
    name: Bump Homebrew formula
    runs-on: ubuntu-latest
    steps:
      - uses: mislav/bump-homebrew-formula-action@v1
        with:
          # A PR will be sent to github.com/Homebrew/homebrew-core to update this formula:
          formula-name: amfora
          download-url: https://github.com/makeworld-the-better-one/amfora.git
        env:
          COMMITTER_TOKEN: ${{ secrets.HOMEBREW_TOKEN }}

Output from failed job:

image

@mislav
Copy link
Owner

mislav commented Dec 14, 2021

I've seen this 404 before but unfortunately I wasn't able to track it down yet. It's not related to download-url. Opening a new issue for that; thank you for reporting!

@makew0rld
Copy link
Author

Too bad, thanks for looking into it. Thanks, a new issue was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants