Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial 2FA auth prompt misaligned #1262

Closed
mgedmin opened this issue Sep 10, 2016 · 4 comments
Closed

Initial 2FA auth prompt misaligned #1262

mgedmin opened this issue Sep 10, 2016 · 4 comments

Comments

@mgedmin
Copy link

mgedmin commented Sep 10, 2016

Here's what my terminal looks like when I use hub fork for the 1st time:

mg@platonas! ~/.vim/bundle/python_open_module [git:master=] $ hub fork
github.com username: mgedmin
github.com password for mgedmin (never stored): 
                                                two-factor authentication code: 758417
Updating mgedmin
From https://github.com/vim-scripts/python_open_module
 * [new branch]      master     -> mgedmin/master
new remote: mgedmin

The two-factor authentication code prompt should not be indented that way.
@mislav
Copy link
Owner

mislav commented Sep 10, 2016

Thanks for reporting! I haven't seen that one yet.

  1. Have you typed a password or pasted it?
  2. Does the password contain characters other than alphanumeric?
  3. Which shell?
  4. Which terminal emulator?

@mislav
Copy link
Owner

mislav commented Sep 10, 2016

Also, of course: which hub version?

@mgedmin
Copy link
Author

mgedmin commented Sep 10, 2016

  1. I typed the password
  2. The password is alphanumeric
  3. bash
  4. GNOME Terminal
$ hub --version
git version 2.7.4
hub version 2.3.0-pre4

(installed today with go get github.com/github/hub)

@mislav
Copy link
Owner

mislav commented Sep 11, 2016

Thanks for the extra info!

@mislav mislav closed this as completed in 70d7bb6 Sep 11, 2016
mislav added a commit that referenced this issue Sep 11, 2016
@mislav
Fix 2FA prompt alignment in the terminal
ef4cdb2 
After the last howeyc/gopass update, hitting Enter after password input
makes the next printed line appear indented to the position of the
password prompt. I'm not sure what causes this, but as a workaround,
skip the howeyc/gopass dependency altogether and interface directly with
crypto/ssh/terminal.

Fixes #1262

See https://groups.google.com/forum/#!topic/golang-nuts/kTVAbtee9UA
@mgedmin mgedmin mentioned this issue Sep 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mislav @mgedmin