Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue and Pull Request Templates, with addendums #1187

Merged
merged 13 commits into from Aug 21, 2016

Commits on May 30, 2016

  1. Implement reading github template from file

    ganmacs authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    470b692 View commit details
    Browse the repository at this point in the history
  2. Support Pull Request tempalte

    ganmacs authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    2cf8451 View commit details
    Browse the repository at this point in the history
  3. Support issue template

    ganmacs authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    05b9c61 View commit details
    Browse the repository at this point in the history
  4. fix typo

    ganmacs authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    085821f View commit details
    Browse the repository at this point in the history
  5. Add GeneratePRTemplate method to github/template

    The function of this method is to defer the logic of generating a commit
    message to template.go, and eventually remove that logic from
    commands/pull_request.go
    
    Also adds tests for this new method, which also modifies the
    fixtures/test_repo.go file to accomidate a test repo with a `.github` PR
    dir.
    NickLaMuro authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    a1e49b8 View commit details
    Browse the repository at this point in the history
  6. Add commit message support for GeneratePRTemplate

    This allows the github.GeneratePRTemplate() function to autofill the
    pull request title for a single commit pull request with either:
    
    * The entire commit message, if it is a single line commit message
    * The first line of the commit message, if it is a multi-line commit
      message
    
    As far as the code is concerned, both cases above are interpreted in the
    same fashion, but the expectations of the user are defined with each of
    the new test cases in github/template_test.go
    
    FYI, this commit message would be an example of a multi line commit
    message :)
    NickLaMuro authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    4a46188 View commit details
    Browse the repository at this point in the history
  7. Implement GeneratePRTemplate in pull_request.go

    Implements the GeneratePRTemplate in pull_request.go instead of the
    custom logic that previously existed in the file.  Addresses:
    
    * Title being defaulted as the first line of the template
    * Commit messages not defaulting as the title only properly
    NickLaMuro authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    fae4730 View commit details
    Browse the repository at this point in the history
  8. Fix typo: issueTempalte => issueTemplate

    For the longest time I was assuming that this was a whitespace change
    with `git diff`, even though I had fixed it when building this a few
    weeks back, so I decided to not bother adding it to the previous
    commits.  When I removed it and re-ran the tests, things stopped
    working... oops :)
    NickLaMuro authored and jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    ad6ac94 View commit details
    Browse the repository at this point in the history
  9. Add template tests

    ganmacs authored and jez committed May 30, 2016
    1 Configuration menu
    Copy the full SHA
    9144e1d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    12b388b View commit details
    Browse the repository at this point in the history
  11. Fix typo (prTempalte -> prTemplate), and fix tests

    These typos were hiding failing tests (i.e., two mistakes were canelling
    each other out and making the tests pass accidentally).
    
    The tests *should* have been failing because the new addGitHubTemplates
    function was writing GitHub templates to the wrong place in the test
    repo fixture. They need to be written inside the repo, not in the same
    directory as the repo.
    jez committed May 30, 2016
    Configuration menu
    Copy the full SHA
    3e8f5bd View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2016

  1. Remove dead code

    jez committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    c141978 View commit details
    Browse the repository at this point in the history
  2. Remove unecessary if

    jez committed Jun 3, 2016
    Configuration menu
    Copy the full SHA
    0de949b View commit details
    Browse the repository at this point in the history