fixing the specs reveals errors in the code... deprecated_add working…

… properly again for tabs
mislav · Dec 20, 2009 · 729f0cd · 729f0cd
1 parent 00b469d
commit 729f0cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/radiant/admin_ui.rb b/lib/radiant/admin_ui.rb
@@ -27,7 +27,7 @@ def [](id)
 
       def <<(*args)
         options = args.extract_options!
-        item = args.size > 1 ? deprecated_add(*(args[1,2] << caller)) : args.first
+        item = args.size > 1 ? deprecated_add(*(args << caller)) : args.first
         raise DuplicateTabNameError.new("duplicate tab name `#{item.name}'") if self[item.name]
         item.tab = self if item.respond_to?(:tab=)
         if options.empty?

diff --git a/spec/lib/radiant/admin_ui/nav_tabs_spec.rb b/spec/lib/radiant/admin_ui/nav_tabs_spec.rb
@@ -67,9 +67,9 @@
 
   it "should warn about using the deprecated add method" do
     ActiveSupport::Deprecation.should_receive(:warn)
-    @tab.add(:pages, "Pages", "/admin/pages")
-    @tab[:pages].name.should == "Pages"
-    @tab[:pages].url.should == "/admin/pages"
+    @tab.add("Pages", "/admin/pages")
+    @tab['Pages'].name.should == "Pages"
+    @tab['Pages'].url.should == "/admin/pages"
   end
 end