Update for paginate_by_sql to support SQL Server #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the paginate_by_sql function to allow for SQL Server syntax. This has been verified to work with activerecord-sqlserver-adapter (3.0.19) but may require additional verification with later gem versions (current is 3.2.11) or other SQL Server Adapters.
|
Thank you, and sorry that I hadn't given this attention earlier. Since we haven't gotten much reports for will_paginate and SQL Server in the meantime, and since I don't have a good way to test against SQL Server, I'm going to attribute this to https://github.com/mislav/will_paginate/wiki#limitations and close as #wontfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the paginate_by_sql function to allow for SQL Server syntax.
This has been verified to work with activerecord-sqlserver-adapter
(3.0.19) but may require additional verification with later gem versions
(current is 3.2.11) or other SQL Server Adapters.