Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The color of hyperlink is not distinguishable from normal text #130

Closed
whhone opened this issue Jan 2, 2020 · 1 comment · Fixed by #132
Closed

The color of hyperlink is not distinguishable from normal text #130

whhone opened this issue Jan 2, 2020 · 1 comment · Fixed by #132

Comments

@whhone
Copy link
Contributor

whhone commented Jan 2, 2020

I am on the release branch 4a8b235.

Expected: The generated HTML should differentiate normal text and hyper link.

Actual: Normal text and hyper link are not distinguishable. Hyper links are not underscored and they have the same color as normal text.
dwmkerr added a commit to dwmkerr/hugo_theme_pickles that referenced this issue Jan 3, 2020
@dwmkerr
fix: use the correct variables for link-color and link-hover
061e559 
Fixes mismith0227#130
@dwmkerr dwmkerr mentioned this issue Jan 3, 2020
Closed
@dwmkerr
Copy link
Contributor

dwmkerr commented Jan 3, 2020 •
edited
Loading

I think PR #132 fixes this but am not very familiar with SCSS!

dwmkerr added a commit to dwmkerr/hugo_theme_pickles that referenced this issue Jan 3, 2020
@dwmkerr
fix: use correct scss variables for link colors
e4aa4f8 
Fixes mismith0227#130.
@dwmkerr dwmkerr mentioned this issue Jan 3, 2020
Merged
mismith0227 added a commit that referenced this issue Jan 3, 2020
@mismith0227
Merge pull request #133 from mismith0227/develop
71d60b9 
fix #130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@whhone @dwmkerr