Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests and Travis config updated #29

Merged
merged 6 commits into from
Jan 20, 2020
Merged

Tests and Travis config updated #29

merged 6 commits into from
Jan 20, 2020

Conversation

adbar
Copy link
Contributor

@adbar adbar commented Jan 14, 2020

Test matrix: further versions added for Linux (3.7, 3.8, 3.9-nightly, pypy) and MacOS

Test matrix: further versions added for Linux (3.7, 3.8, 3.9-nightly, pypy) and MacOS
Rename section to prevent the following error:
Failed: [pytest] section in setup.cfg files is no longer supported, change to [tool:pytest] instead
Try patching pytest versions from https://github.com/pytest-dev/pytest-cov/blob/master/tox.ini to ensure backwards compatibility
lxml.etree.XMLSyntaxError → lxml.etree.ParserError in order to pass tests
@adbar adbar changed the title travis config updated Tests and Travis config updated Jan 14, 2020
@adbar
Copy link
Contributor Author

adbar commented Jan 14, 2020

I just patched and fixed the most part of the tests, a problem remains with Python 3.4, I believe the latest usable version of LXML is 4.3.4, this would have to be set in setup.py.

@adbar
Copy link
Contributor Author

adbar commented Jan 17, 2020

I found a solution and updated setup.py in a further pull request.

@miso-belica
Copy link
Owner

@adbar Thanks for your work. But both PRs failed because they need each other. Can you cherry-pick the commit from #30 here please so we can be sure Travis passes the tests?

@miso-belica miso-belica self-requested a review January 18, 2020 10:11
@miso-belica miso-belica assigned miso-belica and adbar and unassigned miso-belica Jan 18, 2020
LXML versions pinned for older versions of Python which aren't supported anymore

Python versions updated: 2.6 and 3.3 dropped, 3.6 to 3.8 added.
@adbar
Copy link
Contributor Author

adbar commented Jan 20, 2020

✓ thank you for the input.

Copy link
Owner

@miso-belica miso-belica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot :)

@miso-belica miso-belica merged commit 2ae6aca into miso-belica:dev Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants