Add support for the Greek Language #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greetings, Could we do something about this failing test, in order for the pull request to resume? Thank you for your time! |
|
Hi, sorry, I don't think the test is a problem. It is irrelevant. Just I am quite busy with life currently. I hope I'll find time during next weeks for this. |
miso-belica
requested changes
Apr 9, 2022
miso-belica
reviewed
Apr 10, 2022
|
Good evening, I added most of the suggested changes of your review. Kind regards |
miso-belica
approved these changes
Apr 21, 2022
|
Thank you so much for your valuable feedback and the integration of this code. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
As mentioned in the #167 issue I opened earlier, I would like to add support for the Greek Language.
Regarding the license issue, I included a license of LGPL-v3 which covers the usage of the Greek Stemmer module in the
stem_word()function inside sumy/nlp/stemmers/greek.py. This covers the case of considering it a derivative work, since it is a wrapper function built around the Greek Stemmer module. This module was also added in theextras_requiresection insetup.py.I wrote the code for the Greek Sentence and word Tokenizer, and tested it locally using Greek text. I also added two simple test cases in sumy/nlp/stemmers/greek.py. Regarding the extra language specific abbreviations, I included the most common ones I found, and remove the final point
.from each one as mentioned in your code comment. Finally I added a list of Greek stopwords.If you got any feedback/changes, please let me know.
Thank you for your time!