Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

biome registry files are outdated #7

Closed
IoeCmcomc opened this issue Jun 9, 2023 · 3 comments
Closed

biome registry files are outdated #7

IoeCmcomc opened this issue Jun 9, 2023 · 3 comments
Assignees
@misode
Labels
bug Something isn't working ✨ registries

Comments

@IoeCmcomc
Copy link

The files https://github.com/misode/mcmeta/blob/1.20-registries/biome/data.json and https://github.com/misode/mcmeta/blob/1.20-registries/biome/data.min.json haven't been updated since 1.17, thus missing newer biomes such as lush_caves, deep_dark and cherry_grove.
@misode
Copy link
Owner

misode commented Jun 18, 2023

You're right, this is a result of the registry being renamed to worldgen/biome and the mcmeta script is not correctly removing old registry folders.

@misode misode added the bug Something isn't working label Jun 18, 2023
@misode misode self-assigned this Jun 18, 2023
@misode misode closed this as completed in e2e8dec Oct 5, 2023
@misode
Copy link
Owner

misode commented Oct 5, 2023

I pushed the fix for this, but the registries branch is still incorrect until I rerun the script for it.

misode added a commit that referenced this issue Oct 5, 2023
@misode
Add diff export + use pool to fetch resources
1e2a62a 
Also fixes #7
misode added a commit that referenced this issue Oct 5, 2023
@misode
Add diff export + use pool to fetch resources
6c96c31 
Also fixes #7
@misode
Copy link
Owner

misode commented Oct 5, 2023

The registries branch has now been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misode misode

Labels
bug Something isn't working ✨ registries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@misode @IoeCmcomc