Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Breaks When Using a Block Outside of Predefined List #379

Closed
Darkosto opened this issue May 29, 2023 · 1 comment
Closed

Preview Breaks When Using a Block Outside of Predefined List #379

Darkosto opened this issue May 29, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Darkosto
Copy link

Hello!

When using the Noise Settings Generator, the preview will break when using a block outside of this list: https://github.com/misode/misode.github.io/blob/97e996191993899a3bc0e858418dd5c062bd20a1/src/app/components/previews/NoiseSettingsPreview.tsx#LL108C7-L108C18

The preview window will go completely gray until that block is removed from the generation:

image

I believe this happened when PR #322 was merged

Prior to this PR, any block not found on the list would be rendered black.

Thank you!

@misode misode self-assigned this May 29, 2023
@misode misode added the bug Something isn't working label May 29, 2023
@misode misode closed this as completed in a78bb6c May 29, 2023
@misode
Copy link
Owner

misode commented May 29, 2023

@Darkosto Thank you for spotting this and for the report! It has now been fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants