Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advancement generator #50

Merged
merged 14 commits into from
Dec 29, 2019
Merged

Add advancement generator #50

merged 14 commits into from
Dec 29, 2019

Conversation

misode
Copy link
Owner

@misode misode commented Dec 28, 2019

No description provided.

Copy link
Collaborator

@SPGoding SPGoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tool is going to be more awesome!

locales/en.json Outdated Show resolved Hide resolved
@misode misode marked this pull request as ready for review December 29, 2019 01:01
@misode
Copy link
Owner Author

misode commented Dec 29, 2019

This branch is missing the requirements property, because I'm not sure how to structure that in a compact way. Worst case it would just be a simple text field.

@misode misode requested a review from SPGoding December 29, 2019 01:02
@misode
Copy link
Owner Author

misode commented Dec 29, 2019

I also noticed that this breaks the apply_bonus function, but since there is a refactor planned I think I can live with that.

@misode misode merged commit e8560fb into master Dec 29, 2019
@misode misode deleted the advancements branch December 29, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants