Skip to content

Commit

Permalink
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
Browse files Browse the repository at this point in the history
… __new__ (pythonGH-114160)

(cherry picked from commit 33b47a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
  • Loading branch information
ethanfurman authored and miss-islington committed Jan 17, 2024
1 parent 74a6b7f commit 3048a26
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Lib/enum.py
Expand Up @@ -254,7 +254,7 @@ def __set_name__(self, enum_class, member_name):
delattr(enum_class, member_name)
# second step: create member based on enum_class
value = self.value
if not isinstance(value, tuple):
if type(value) is not tuple:
args = (value, )
else:
args = value
Expand Down Expand Up @@ -1757,7 +1757,7 @@ def convert_class(cls):
else:
# create the member
if use_args:
if not isinstance(value, tuple):
if type(value) is not tuple:
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
Expand Down Expand Up @@ -1807,7 +1807,7 @@ def convert_class(cls):
else:
# create the member
if use_args:
if not isinstance(value, tuple):
if type(value) is not tuple:
value = (value, )
member = new_member(enum_class, *value)
value = value[0]
Expand Down
16 changes: 16 additions & 0 deletions Lib/test/test_enum.py
Expand Up @@ -3163,6 +3163,22 @@ class NTEnum(Enum):
[x.value for x in NTEnum],
[TTuple(id=0, a=0, blist=[]), TTuple(id=1, a=2, blist=[4]), TTuple(id=2, a=4, blist=[0, 1, 2])],
)
#
class NTDEnum(Enum):
def __new__(cls, t_value):
member = object.__new__(cls)
member._value_ = t_value[0]
member.id = t_value[0]
member.a = t_value[1]
member.blist = t_value[2]
return member
NONE = TTuple(0, 0, [])
A = TTuple(1, 2, [4])
B = TTuple(2, 4, [0, 1, 2])
self.assertEqual(repr(NTDEnum.NONE), "<NTDEnum.NONE: 0>")
self.assertEqual(NTDEnum.NONE.id, 0)
self.assertEqual(NTDEnum.A.a, 2)
self.assertEqual(NTDEnum.B.blist, [0, 1 ,2])

def test_flag_with_custom_new(self):
class FlagFromChar(IntFlag):
Expand Down
@@ -0,0 +1 @@
Enum: correctly handle tuple subclasses in custom ``__new__``.

0 comments on commit 3048a26

Please sign in to comment.