Feat/modification formulaire #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge into feat/campagnes-saisie-intentions
…ge into feat/campagnes-saisie-intentions
…ge into feat/campagnes-saisie-intentions
LucasDetre
force-pushed
the
feat/modification-formulaire
branch
from
d43ed55
to
50b1841
Compare
…ge into feat/modification-formulaire
gBusato
reviewed
Apr 15, 2024
| @@ -49,6 +49,13 @@ export interface DB extends Omit<DBSchema, "formationNonMaterializedView"> { | |||
| >; | |||
| }; | |||
| } | |||
| export interface DB extends Omit<DBSchema, "latestDemandeView"> { | |||
There was a problem hiding this comment.
Je m'intérroge sur les multiples exports d'interface DB, on ne peut pas regrouper tout ça dans une seule ?
gBusato
reviewed
Apr 15, 2024
gBusato
reviewed
Apr 15, 2024
server/src/modules/core/usecases/getCampagnes/getCampagnes.route.ts
Outdated
Show resolved
Hide resolved
gBusato
reviewed
Apr 15, 2024
gBusato
reviewed
Apr 15, 2024
| eb( | ||
| sql`unaccent(${eb.ref("discipline.libelleDiscipline")})`, | ||
| "ilike", | ||
| `%${search_word |
There was a problem hiding this comment.
C'est pas la première fois qu'on a besoin de normaliser un texte de recherche, ça vaudrait le coup de créer une méthode globale qu'on pourrait réutiliser
gBusato
reviewed
Apr 15, 2024
server/src/modules/intentions/repositories/updateDemandeWithHistory.query.ts
Outdated
Show resolved
Hide resolved
gBusato
reviewed
Apr 15, 2024
server/src/modules/intentions/usecases/countDemandes/countDemandes.usecase.ts
Show resolved
Hide resolved
gBusato
reviewed
Apr 15, 2024
server/src/modules/intentions/usecases/deleteDemande/deleteDemande.route.ts
Outdated
Show resolved
Hide resolved
gBusato
reviewed
Apr 15, 2024
| user: Pick<RequestUser, "id" | "role" | "codeRegion">; | ||
| }) => { | ||
| const demande = await deps.findOneDemande(id); | ||
| const demande = await deps.findOneDemande(numero); | ||
| if (!demande) throw Boom.notFound(); | ||
|
|
||
| const scope = getPermissionScope(user.role, "intentions/ecriture"); |
There was a problem hiding this comment.
Cette règle de vérification pourrait potentiellement être faite coté DB avec des RLS
gBusato
reviewed
Apr 15, 2024
server/src/modules/intentions/usecases/getDefaultCampagne/getDefaultCampagne.route.ts
Outdated
Show resolved
Hide resolved
gBusato
reviewed
Apr 15, 2024
server/src/modules/intentions/usecases/getDefaultCampagne/getDefaultCampagne.usecase.ts
Outdated
Show resolved
Hide resolved
gBusato
reviewed
Apr 16, 2024
| @@ -1,4 +1,6 @@ | |||
| import * as uuid from "uuid"; | |||
|
|
|||
| export const generateId = () => | |||
| export const generateId = () => uuid.v4().replace(/-/g, ""); | |||
There was a problem hiding this comment.
utilise des ulid dans ce cas, tu pourras les ordonner de manière alphabhétique, chose qui n'est pas le cas la
gBusato
reviewed
Apr 16, 2024
gBusato
reviewed
Apr 16, 2024
gBusato
reviewed
Apr 16, 2024
...pped)/intentions/saisie/intentionForm/typeDemandeSection/capaciteSection/CapaciteSection.tsx
Show resolved
Hide resolved
gBusato
reviewed
Apr 16, 2024
...ns/saisie/intentionForm/typeDemandeSection/capaciteSection/CapaciteScolaireActuelleField.tsx
Outdated
Show resolved
Hide resolved
…ge into feat/modification-formulaire
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker version obsolète reference : https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md
Documentation capacité : https://www.notion.so/R-gles-de-validation-des-capacit-s-574f33e0ac0f427da8c53482ec1d0b16