Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST Platform: NC EOS switches #1717

Open
toomanybrians opened this issue Oct 12, 2023 · 2 comments
Open

FAST Platform: NC EOS switches #1717

toomanybrians opened this issue Oct 12, 2023 · 2 comments

Comments

@toomanybrians
Copy link
Member

In MPF 0.57, it appears the FAST platform is not respecting NO versus NC for EOS switches in flipper configs. The unit tests do not cover this.

@toomanybrians
Copy link
Member Author

It looks like something isn’t working here. When the flipper button associated with the flipper goes inactive, it sends a TL:xx,02 command to disable the flipper. 🤷‍♂️ I would guess this has nothing to do with the NC EOS and is an EOS thing in general in 0.57, but who knows. I’ll try to set up some tests to reproduce this.

@toomanybrians toomanybrians reopened this Oct 15, 2023
@toomanybrians
Copy link
Member Author

Log showing the flipper autofires disabling:

2023-10-15 12:49:55,861 : INFO : SwitchController : <<<<<<< 's_left_flipper' inactive >>>>>>>
2023-10-15 12:49:55,861 : DEBUG : FAST Driver : Disabling driver 30
2023-10-15 12:49:55,861 : DEBUG : FAST Driver : Disabling driver 25
2023-10-15 12:49:55,861 : INFO : [NET] : >>>> TL:1E,02
2023-10-15 12:49:55,861 : INFO : [NET] : >>>> TL:19,02

I wrote a test which passes. 🤷‍♂️ The only thing I can think of is the tests don't have a game running, so maybe something there affects it? I cannot reproduce this locally, so who knows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant