Skip to content

Commit

Permalink
Support all short_names when getting emoji data [Fix #15]
Browse files Browse the repository at this point in the history
  • Loading branch information
EtienneLem committed Oct 13, 2016
1 parent 00eea58 commit 2aece93
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
8 changes: 6 additions & 2 deletions scripts/build-data.js
Expand Up @@ -5,7 +5,7 @@ var fs = require('fs'),
mkdirp = require('mkdirp')

var categories = ['People', 'Nature', 'Foods', 'Activity', 'Places', 'Objects', 'Symbols', 'Flags'],
data = { categories: [], emojis: {}, skins: {} },
data = { categories: [], emojis: {}, skins: {}, short_names: {} },
categoriesIndex = {}

categories.forEach((category, i) => {
Expand All @@ -22,7 +22,6 @@ emojiData.sort((a, b) => {

emojiData.forEach((datum) => {
var category = datum.category,
shortName = datum.short_name,
keywords = [],
categoryIndex

Expand Down Expand Up @@ -83,6 +82,11 @@ emojiData.forEach((datum) => {
data.emojis[datum.short_name] = datum
}

datum.short_names.forEach((short_name, i) => {
if (i == 0) { return }
data.short_names[short_name] = datum.short_name
})

delete datum.docomo
delete datum.au
delete datum.softbank
Expand Down
10 changes: 9 additions & 1 deletion src/utils/index.js
Expand Up @@ -37,13 +37,21 @@ function getSanitizedData() {

function getData(emoji, skin, sheetURL) {
var emojiData = {},
_emojiData = null
_emojiData, _emoji, _id

if (typeof emoji == 'string') {
if (_emoji = data.short_names[emoji]) {
emoji = _emoji
}

if (_emojiData = data.emojis[emoji]) {
emojiData = _emojiData
}
} else if (emoji.id) {
if (_id = data.short_names[emoji.id]) {
emoji.id = _id
}

if (_emojiData = data.emojis[emoji.id]) {
emojiData = _emojiData
skin || (skin = emoji.skin)
Expand Down

0 comments on commit 2aece93

Please sign in to comment.