Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab-bag of accessibility issues #294

Closed
5 tasks done
nolanlawson opened this issue Mar 12, 2019 · 2 comments
Closed
5 tasks done

Grab-bag of accessibility issues #294

nolanlawson opened this issue Mar 12, 2019 · 2 comments

Comments

@nolanlawson
Copy link

nolanlawson commented Mar 12, 2019

After merging #281 #282 #283 #284, there are still some remaining a11y issues I'd like to tackle:

  • title emoji is decorative, should be aria-hidden
  • title text should be a title for the whole thing, using aria-labelledby or something
  • skintone picker should better communicate pressed and dropdown states
  • the list of emoji in each category should use <ul>/<li>
  • overall structure of regions/landmarks could be improved
@nolanlawson
Copy link
Author

Given that VoiceOver seems to flatten all regions, we can probably remove the "list of emojis" section. That gives us one less i18n string to maintain anyway.

However, we should probably add "search" to the list of regions, since otherwise it's missing when you look at the list of regions.

nolanlawson added a commit to nolanlawson/emoji-mart that referenced this issue Mar 12, 2019
@nolanlawson
Copy link
Author

There could be additional improvements, especially in the skintone picker, but for now I think these are largely fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant