Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit dependency on core-js #393

Closed
nolanlawson opened this issue Dec 24, 2019 · 3 comments · Fixed by #394
Closed

Implicit dependency on core-js #393

nolanlawson opened this issue Dec 24, 2019 · 3 comments · Fixed by #394
Labels
bug performance

Comments

@nolanlawson
Copy link

Unfortunately, it looks like we allowed core-js to sneak into our dependencies, due to Object.values() (#351) and JSON.stringify (#392).

This adds about ~5kB extra to the bundle size, and of course will break if someone doesn't have core-js in their dependencies, since it's an implicit dependency.
@nolanlawson nolanlawson mentioned this issue Dec 24, 2019
Merged
@nolanlawson nolanlawson changed the title Remove core-js dependency Implicit dependency on core-js Dec 24, 2019
@nolanlawson nolanlawson mentioned this issue Dec 29, 2019
Merged
@saltire saltire mentioned this issue Jan 14, 2020
Closed
@mefu
Copy link

mefu commented Jan 21, 2020

Can you please release a version that includes this fix?

@Mamaduka Mamaduka mentioned this issue Jan 21, 2020
Closed
@EtienneLem
Copy link
Member

Will do very soon

@lastnigtic
Copy link

lastnigtic commented Jul 28, 2021 •
edited

It seems that the patch version has not been released yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove core-js dependency missive/emoji-mart
4 participants
@nolanlawson @EtienneLem @mefu @lastnigtic