Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 16 #123

Merged
merged 3 commits into from
Sep 28, 2017
Merged

Upgrade to React 16 #123

merged 3 commits into from
Sep 28, 2017

Conversation

Gargron
Copy link

@Gargron Gargron commented Sep 27, 2017 •
edited
Loading

Fix #122

  • Upgrade React to 16.0.0
  • Replace deprecated ref syntax
  • Upgrade Webpack to 3.6.0
  • Upgrade minor dependencies that don't have breaking changes

@Gargron Gargron changed the title Upgrade to React 16, do not use deprecated ref syntax Upgrade to React 16 Sep 27, 2017
@Gargron
Copy link
Author

Gargron commented Sep 27, 2017

I don't know if measure-scrollbar should be in dependencies, isn't the final product compiled so no runtime dependencies are needed?

@Gargron Gargron mentioned this pull request Sep 27, 2017
Merged
@EtienneLem EtienneLem merged commit f8358ff into missive:master Sep 28, 2017
@EtienneLem
Copy link
Member

Thanks! 🤘

I don't know if measure-scrollbar should be in dependencies

Mmh, I guess you’re right! I’ll check that out.

@Gargron Gargron deleted the feature-react-16 branch September 28, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gargron @EtienneLem