Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing down a recent prop instead of localStorage #132

Merged
merged 2 commits into from Oct 30, 2017

Conversation

Gargron
Copy link

@Gargron Gargron commented Oct 7, 2017

Fix #129 - Since the only things the store is used for is the "recent emojis" functionality and skin modifier persistence, if you pass down recent emojis through props and showPreview=false, the store will never be hit.

@nightpool
Copy link

Since this adds a new property, it needs README documentation, right?

@nolanlawson
Copy link

LGTM, I appreciate that it just doesn't even write or read from localStorage at all if you pass in recent. It's conceivable users would want to handle this themselves or use some other store (IndexedDB, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants