keep short_names on sanitize #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
And yes we could probably go through the codebase and try to handle all cases where |
|
Wait, don't we need |
|
Oh, I didn't face the problem with non-custom emoji, but it looks to need that to make interface uniform! |
|
I also can't seem to write a Jest test to reproduce this, but I am new to Jest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emoji-mart/src/components/emoji/nimble-emoji.js
Line 118 in d739f27
throws
TypeError: Cannot read property '0' of undefined. (It makes mastodon/mastodon#10315 )This is one of way to resolve issue, but it may not a good way.