fix: remove rAF polyfill, add SSR test #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
force-pushed
the
nolan/test-ssr
branch
from
7baa07f
to
835c2e9
Compare
|
Rebased, fixed conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the rAF polyfill is only needed for SSR support (#7). rAF has been available in browsers since IE10 so it's unlikely we need it for browser support.
This PR adds a test (
yarn test:ssr) to make sure that SSR is working correctly, and also removes the rAF polyfill. As the test demonstrates, we don't actually use rAF in any of therender()function (only on button clicks or similar interactions), so we can safely remove it AFAICT.