Do not store recently used if 'recent' category is excluded. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneLem
requested changes
May 27, 2017
src/components/picker.js
Outdated
| @@ -87,6 +89,7 @@ export default class Picker extends React.Component { | |||
| let includeRecent = props.include == undefined ? true : props.include.indexOf('recent') > -1 | |||
| let excludeRecent = props.exclude == undefined ? false : props.exclude.indexOf('recent') > -1 | |||
| if (includeRecent && !excludeRecent) { | |||
| this.hideRecent = true | |||
There was a problem hiding this comment.
I think this should be the other way around, right?
|
Thanks for checking my mistake @EtienneLem - all good now. 😊 |
EtienneLem
approved these changes
May 29, 2017
|
Sweet, thanks! 🤘 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
recentcategory is excluded, this PR ensures that the Picker respects this and does not write to local storage anyway.Previously, recent usage would be written to storage even if the
recentcategory was ignored.