Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add support for custom emojis #85

Merged
merged 18 commits into from
May 27, 2017
Merged

[WIP] Add support for custom emojis #85

merged 18 commits into from
May 27, 2017

Commits on May 24, 2017

  1. Document custom emoji support

    @sonicdoe
    sonicdoe committed May 24, 2017
    Configuration menu
    Copy the full SHA
    00dce20 View commit details
    Browse the repository at this point in the history

  2. Split out generation of search property

    @sonicdoe
    sonicdoe committed May 24, 2017
    Configuration menu
    Copy the full SHA
    d9c0139 View commit details
    Browse the repository at this point in the history

  3. Add support for custom emojis to getData()

    @sonicdoe
    sonicdoe committed May 24, 2017
    Configuration menu
    Copy the full SHA
    15c7b27 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2017

  1. Guard buildSearch() against undefined properties 

    This is important if custom emojis don’t specify any emoticons, for example.
    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    2f7d6eb View commit details
    Browse the repository at this point in the history

  2. Add support for custom emojis to sanitize()

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    a28f043 View commit details
    Browse the repository at this point in the history

  3. Add support for custom emojis to <Emoji />

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    d181379 View commit details
    Browse the repository at this point in the history

  4. Add support for custom emojis to <Picker />

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    d237edc View commit details
    Browse the repository at this point in the history

  5. Add custom emojis to example page

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    7ce0f8e View commit details
    Browse the repository at this point in the history

  6. Pass custom emoji data directly to <Preview /> 

    <Preview /> calls getData() itself which will fail for custom emojis because there is no universally available data source for custom emojis. To work around this, we pass the custom emoji data (which <Picker /> received via the `custom` prop) directly to <Preview />.
    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    289fc0f View commit details
    Browse the repository at this point in the history

  7. Add support for custom emojis to EmojiIndex#search

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    e10a779 View commit details
    Browse the repository at this point in the history

  8. Pass custom emojis to EmojiPicker#search

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    2fdd9fe View commit details
    Browse the repository at this point in the history

  9. Add icon for custom category

    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    153998c View commit details
    Browse the repository at this point in the history

  10. Guard sanitize() against undefined short_names 

    This is important when hovering over a custom emoji while searching.
    @sonicdoe
    sonicdoe committed May 26, 2017
    Configuration menu
    Copy the full SHA
    346e398 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2017

  1. Merge branch 'master' into custom-emojis

    @EtienneLem
    EtienneLem committed May 27, 2017
    Configuration menu
    Copy the full SHA
    1b77cb8 View commit details
    Browse the repository at this point in the history

  2. Add include/exclude support to custom emojis

    @EtienneLem
    EtienneLem committed May 27, 2017
    Configuration menu
    Copy the full SHA
    d8b4c81 View commit details
    Browse the repository at this point in the history

  3. Make sure last category is selected when scrolled to bottom

    @EtienneLem
    EtienneLem committed May 27, 2017
    Configuration menu
    Copy the full SHA
    e28dc4d View commit details
    Browse the repository at this point in the history

  4. Add “Frequently Used” support to custom emojis

    @EtienneLem
    EtienneLem committed May 27, 2017
    Configuration menu
    Copy the full SHA
    e95f515 View commit details
    Browse the repository at this point in the history

  5. Use emoji object in emojisToShowFilter 

    So that custom emojis can also be filtered if need be
    @EtienneLem
    EtienneLem committed May 27, 2017
    Configuration menu
    Copy the full SHA
    98f2a95 View commit details
    Browse the repository at this point in the history