Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.12.0-beta.5] Cannot read properties of undefined (reading '0') at FederatedInstanceService.update #10787

Closed
fruitriin opened this issue May 7, 2023 · 11 comments
Labels
🐛Bug Unexpected behavior packages/backend Server side specific issue/PR

Comments

@fruitriin
Copy link
Contributor

💡 Summary

May 07 10:13:57 MisskeySystems misskey[7704]: TypeError: Cannot read properties of undefined (reading '0')
May 07 10:13:57 MisskeySystems misskey[7704]: at FederatedInstanceService.update (file:///root/misskey/packages/backend/built/core/FederatedInstanceService.js:62:35)
May 07 10:13:57 MisskeySystems misskey[7704]: at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

これによって何が起きているのかは調べてない
13.11の不正データかも

🥰 Expected Behavior

🤬 Actual Behavior

📝 Steps to Reproduce

📌 Environment

Misskey version:
PostgreSQL version:
Redis version:
Your OS:
Your browser:

@fruitriin fruitriin added the ⚠️bug? This might be a bug label May 7, 2023
@tamaina
Copy link
Member

tamaina commented May 7, 2023

const i = await this.instancesRepository.insert({
id: this.idService.genId(),
host,
firstRetrievedAt: new Date(),
}).then(x => this.instancesRepository.findOneByOrFail(x.identifiers[0]));

ここら辺?

@fruitriin
Copy link
Contributor Author

ここのthen でreturn response.raw[0] したものが await の戻りのresultになって、 result.raw[0] から値とってるけどこれあってるかな?
斜め読みだから自信はない

@sasagar
Copy link
Contributor

sasagar commented May 9, 2023

same hereです。
一応13.10.3からのアップデートで発生。

@syuilo
Copy link
Member

syuilo commented May 9, 2023

@nexryai
Copy link
Contributor

nexryai commented May 9, 2023

同様の問題が発生しました。ログをリアルタイムでみてると少なくとも5秒に1回は発生しててヤバそう
image
image

@syuilo
Copy link
Member

syuilo commented May 9, 2023

あーローカルでも再現

@syuilo
Copy link
Member

syuilo commented May 9, 2023

tasukete

@ryanho
Copy link
Contributor

ryanho commented May 9, 2023

After upgraded my instance I got the same error message. Using 13.12.0 docker image.

TypeError: Cannot read properties of undefined (reading '0') at FederatedInstanceService.update (file:///misskey/packages/backend/built/core/FederatedInstanceService.js:62:35) at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@syuilo
Copy link
Member

syuilo commented May 9, 2023

うーむ問題ないはずなんだけど
https://stackoverflow.com/a/64116762

@syuilo
Copy link
Member

syuilo commented May 9, 2023

あー

@syuilo syuilo closed this as completed in b2f6c67 May 9, 2023
@syuilo syuilo added 🐛Bug Unexpected behavior packages/backend Server side specific issue/PR and removed ⚠️bug? This might be a bug labels May 9, 2023
@fruitriin
Copy link
Contributor Author

:igyo:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior packages/backend Server side specific issue/PR
Projects
None yet
Development

No branches or pull requests

6 participants