Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing notifications in the settings is missing feedback #8653

Closed
pixeldesu opened this issue May 12, 2022 · 2 comments
Closed

Clearing notifications in the settings is missing feedback #8653

pixeldesu opened this issue May 12, 2022 · 2 comments
Labels
1️⃣ Good First Issue ✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR

Comments

@pixeldesu
Copy link
Contributor

Summary

Currently, clearing the notifications over any button on /settings/notifications does not give any feedback. The notification count might be cleared, but if it isn't visible, nothing is happening for the user even if the request succeeds.

Some feedback using one of the success popups (like os.success()) should be given.
@pixeldesu pixeldesu added the ✨Feature This adds/improves/enhances a feature label May 12, 2022
@Johann150 Johann150 added packages/frontend Client side specific issue/PR 1️⃣ Good First Issue labels May 12, 2022
@Johann150
Copy link
Contributor

I think using os.apiWithDialog for those API requests makes the most sense to fix this.

Jeder321 pushed a commit to Jeder321/misskey that referenced this issue Aug 15, 2022
@Johann150
fix: provide feedback when marking all notifs as read
dc9bfff 
See also misskey-dev#8653
@kakkokari-gtyih
Copy link
Contributor

already fixed in v2024.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1️⃣ Good First Issue ✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pixeldesu @Johann150 @kakkokari-gtyih