Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entire post clickable #8804

Open
ThatOneCalculator opened this issue Jun 9, 2022 · 16 comments
Open

Make entire post clickable #8804

ThatOneCalculator opened this issue Jun 9, 2022 · 16 comments
Labels
✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR

Comments

@ThatOneCalculator
Copy link
Contributor

Summary

Most (if not all) other SNS's have it so clicking/tapping anywhere on a post expands the post, many new users find it unintuitive/confusing to have to click just the timestamp.

@ThatOneCalculator ThatOneCalculator added the ✨Feature This adds/improves/enhances a feature label Jun 9, 2022
@syuilo syuilo added the packages/frontend Client side specific issue/PR label Jun 9, 2022
@Johann150
Copy link
Contributor

Most (if not all) other SNS's have it so clicking/tapping anywhere on a post expands the post

This does not seem to be the case for Pleroma. It behaves similarly to Misskey in that you have to click on the timestamp to get to the page of the post.

I think it might also cause issues in conjunction with the timeline automatically scrolling down when new notes appear.

In my personal opinion it is also annoying if you e.g. want to copy a piece of text from a post and do not need to go to the posts page.

@ThatOneCalculator
Copy link
Contributor Author

ThatOneCalculator commented Jun 13, 2022

Misskey Tweaks does it in a fairly elegant way, you can still select text and not enter a post, but clicking on the post body takes you into the replies.

Also,

This does not seem to be the case for Pleroma. It behaves similarly to Misskey in that you have to click on the timestamp to get to the page of the post.

Pleroma FE is probably the least user-friendly FE for any SNS, especially for people new to the Fediverse.

@viasux
Copy link

viasux commented Oct 30, 2022

Most (if not all) other SNS's have it so clicking/tapping anywhere on a post expands the post

This does not seem to be the case for Pleroma. It behaves similarly to Misskey in that you have to click on the timestamp to get to the page of the post.

I think it might also cause issues in conjunction with the timeline automatically scrolling down when new notes appear.

In my personal opinion it is also annoying if you e.g. want to copy a piece of text from a post and do not need to go to the posts page.

I don't think anyone wants selecting text to expand the post, they want a twitter-like experience.

@syuilo
Copy link
Member

syuilo commented Nov 12, 2022

やるか

@ThatOneCalculator
Copy link
Contributor Author

If you look at Calckey's implementation and like it, I could PR it :)

@panosda
Copy link

panosda commented Nov 14, 2022

If you look at Calckey's implementation and like it, I could PR it :)

It's nice but it's not very easy to understand, the cursor has to turn into a hand over clickable areas. I understood how it works by mistake. We have done this modification in our calckey instance, it you want I could ask Jon to PR this to you first, works nicely.

@ThatOneCalculator
Copy link
Contributor Author

Yea, if you could PR it that'd be great

@futchitwo
Copy link
Contributor

I chose to improve the menu and make the entire post clickable
#9165 (comment)

@syuilo make the entire post clickable はもう実装されてる?
ただco.misskey.io と p1.a9z.dev でノートをタッチしたけど詳細ページが表示されなかった

@syuilo
Copy link
Member

syuilo commented Jan 8, 2023

されてない

@syuilo
Copy link
Member

syuilo commented Jan 8, 2023

現時点でする必要性もそこまで感じてない

@syuilo
Copy link
Member

syuilo commented Jan 15, 2023

メニューや時間から行けるし要らないと思う

@syuilo syuilo closed this as completed Jan 15, 2023
@futchitwo
Copy link
Contributor

えー

@syuilo
Copy link
Member

syuilo commented Mar 2, 2023

リアクションしようとしたときにレイアウトシフトが起きると投稿をクリックしたことになって遷移が発生することになるのはストレスになりそう

@Khsmty
Copy link
Contributor

Khsmty commented Mar 2, 2023

どうなんでしょう、、
リアクションしようとしてレイアウトシフトした時って大抵ノートが画面外に行ってて探す手間があるので
もし遷移してくれたら個人的には嬉しいかもと思ったり…

@saschanaz
Copy link
Member

投稿をクリックして投稿ページを開けてタイムラインに戻ったら以前の位置を失う問題を先に解決しないとかなりストレスになるかもです

@acid-chicken
Copy link
Member

個人的な話として断ると、タッチデバイスでスクロールする際に稀にタッチ判定されてスクロールが阻害されたり、投稿内テキストを選択できなくなる UI への体験がすごく悪いので、例えタップして遷移するケースがそこそこあったとて使いやすいかは別だと思う

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature packages/frontend Client side specific issue/PR
Projects
None yet
Development

No branches or pull requests

9 participants