Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add detail link to note menu and note element #9165

Closed
wants to merge 5 commits into from

Conversation

fu5ha
Copy link
Contributor

@fu5ha fu5ha commented Nov 11, 2022

Fixes #9164

What

(Hopefully) add "detail" link to note and note menu, i.e. the menu shown under "..." or on right click on a note.

image

image

Why

See #9164

Additional info

I didn't test the functionality of the item in the note menu yet 馃槄 Also, it may be desirable to put either of these links in different positions within the UI, i.e. move up or down the list.

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 11, 2022
@fu5ha fu5ha changed the title [feat] Add detail link to note menu and [feat] Add detail link to note menu and note element Nov 11, 2022
@fu5ha fu5ha changed the title [feat] Add detail link to note menu and note element feat: Add detail link to note menu and note element Nov 11, 2022
@syuilo
Copy link
Member

syuilo commented Nov 12, 2022

I chose to improve the menu and make the entire post clickable instead of adding a new button.
ref. #9166
Thanks anyway馃檹

@syuilo syuilo closed this Nov 12, 2022
@fu5ha
Copy link
Contributor Author

fu5ha commented Nov 12, 2022

Heh looks like nenohi opened a pr with much the same as this. Sounds good!

@fu5ha fu5ha deleted the fu5ha/detail-in-hamburger branch November 12, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "details" link to note/note menu
3 participants