enhance: make pwa icon maskable #10033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍🏻 |
yu256
pushed a commit
to yu256/akatsukey
that referenced
this pull request
Feb 23, 2023
syuilo
added a commit
that referenced
this pull request
Feb 23, 2023
* ci: swcにしたためtypecheckは別途実施 * 🎨 * Update package.json * マイグレーションが失敗することがあるのを修正 * refactor ci * use tsc for build Windowsだとエラーが出るため * feat: swc build in windows (#10032) * feat: add optional swc * fix: windowsで動かない現象を修正 * fix: fix swc path alias * fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更 * use swc * chore(client): tweak custom emoji size * enhance: make pwa icon maskable (#10033) * 🎨 * feat(server): add @swc/core-android-arm64 to optional (#10034) * feat: add optional swc * fix: windowsで動かない現象を修正 * fix: fix swc path alias * fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更 * feat(server): add @swc/core-android-arm64 to optional * fix: conflict * Update package.json * chore(backend): fix indent * Update CHANGELOG.md * compress png --------- Co-authored-by: CaffeinePower <86540016+cffnpwr@users.noreply.github.com> Co-authored-by: Shogo Sensui <shogosensui@gmail.com> Co-authored-by: tamaina <tamaina@hotmail.co.jp>
AyumuNekozuki
added a commit
to AyumuNekozuki/misskey
that referenced
this pull request
Feb 27, 2023
* ci: swcにしたためtypecheckは別途実施 * 🎨 * Update package.json * マイグレーションが失敗することがあるのを修正 * refactor ci * use tsc for build Windowsだとエラーが出るため * feat: swc build in windows (misskey-dev#10032) * feat: add optional swc * fix: windowsで動かない現象を修正 * fix: fix swc path alias * fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更 * use swc * chore(client): tweak custom emoji size * enhance: make pwa icon maskable (misskey-dev#10033) * 🎨 * feat(server): add @swc/core-android-arm64 to optional (misskey-dev#10034) * feat: add optional swc * fix: windowsで動かない現象を修正 * fix: fix swc path alias * fix: docker build時に`Host key verification failed`と言われてgitリポジトリからパッケージをインストールできないのでssh -> htpsに変更 * feat(server): add @swc/core-android-arm64 to optional * fix: conflict * Update package.json * chore(backend): fix indent * Update CHANGELOG.md * compress png --------- Co-authored-by: CaffeinePower <86540016+cffnpwr@users.noreply.github.com> Co-authored-by: Shogo Sensui <shogosensui@gmail.com> Co-authored-by: tamaina <tamaina@hotmail.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the current icon for PWA maskable.
Why
Because an installed PWA looks like below.
And current icon seems to be maskable already so by having this change PWA users would see a better-looking misskey icon on their desktop.