Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): MFMのx2, scale, positionが含まれていたらノートをたたむようにした #10165

Merged
merged 6 commits into from
May 31, 2023

Conversation

kabo2468
Copy link
Contributor

@kabo2468 kabo2468 commented Mar 1, 2023

#9882 (comment)

警告ダイアログが出る条件でたたむようになった

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #10165 (c023bb8) into develop (75888a5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #10165   +/-   ##
========================================
  Coverage    75.14%   75.14%           
========================================
  Files          876      876           
  Lines        85580    85583    +3     
  Branches      5807     5811    +4     
========================================
+ Hits         64305    64308    +3     
  Misses       21275    21275           
Impacted Files Coverage Δ
packages/frontend/src/components/MkNote.vue 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kabo2468
Copy link
Contributor Author

kabo2468 commented Mar 1, 2023

#7478 #10031 もやりたいので

const collapsed = $ref(
props.note.cw == null && props.note.text != null && (
(props.note.text.split('\n').length > 9) ||
(props.note.text.length > 500)
));
も同じ条件でまとめたいんですけど、これってscriptsに作っちゃっていいんですかね?
PRは分ける予定です

@syuilo
Copy link
Member

syuilo commented Mar 1, 2023

positionを含める理由って何かしら

@kabo2468
Copy link
Contributor Author

kabo2468 commented Mar 1, 2023

positionを使ったMFM芸は空白ができがちなので含めた

って書いてる途中でpositionだけ使ったものは別に邪魔でもないかもしれないと思った

@tamaina tamaina requested a review from syuilo April 14, 2023 07:01
@u1-liquid
Copy link
Sponsor Contributor

7478 と 10031 は割とよく問題になってるのでできれば早く解決したいかも
positionは抜いてscriptsに入れてもいいんじゃないですかね

@syuilo syuilo merged commit aba0755 into misskey-dev:develop May 31, 2023
@syuilo
Copy link
Member

syuilo commented May 31, 2023

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants