Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sdk v3 に関する仕様変更と修正 #10410

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

yszkst
Copy link
Contributor

@yszkst yszkst commented Mar 25, 2023

What

オブジェクトストレージリージョンが空文字列のときAWS-SDKに渡す値をundefinedにする。

Why

#10408

Additional info (optional)

文言

Crowdin の作法がわからなかったので変更案を置きます

キー objectStorageRegionDesc

ja-JP
'xx-east-1'のようなregionを指定してください。使用サービスにregionの概念がない場合は'us-east-1'にしてください。AWS設定ファイルまたは環境変数を参照する場合は空にしてください。 

en-US
Specify a region like 'xx-east-1'. If your service does not distinguish between regions, enter 'us-east-1' If you use a shared config file or enviroment variables, leave this blank.

仕様変更

aws-sdkが未指定のリージョンに対してv2とv3で挙動が異なるのでリリースノートへ追加が必要かと思いましたが、リリース済みのバージョンに追加してしまってよいか悩んだのでここに置きます。

### Changes
- オブジェクトストレージのリージョン指定が必須になりました
  - リージョンの指定の無いサービスは us-east-1 を設定してください
  - 値が空の場合は設定ファイルまたは環境変数の使用を試みます
    - e.g. ~/aws/config, AWS_REGION

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #10410 (c0a4849) into develop (5be5445) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #10410      +/-   ##
===========================================
- Coverage    75.07%   75.07%   -0.01%     
===========================================
  Files          879      879              
  Lines        86017    86017              
  Branches      5837     5834       -3     
===========================================
- Hits         64576    64573       -3     
- Misses       21441    21444       +3     
Impacted Files Coverage Δ
packages/backend/src/core/S3Service.ts 97.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 31cc188 into misskey-dev:develop Mar 25, 2023
@syuilo
Copy link
Member

syuilo commented Mar 25, 2023

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants