Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ドライブのファイルアップロードでサーバーが413を返した場合にエラーメッセージを表示 #10680

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

tinaxd
Copy link
Contributor

@tinaxd tinaxd commented Apr 21, 2023

What

Fix #8574
ドライブのファイルアップロード機能でサーバーがステータスコード413を返した際に、フロントエンドでエラーダイアログが出るように修正しました。
image

Why

サーバーが200番以外のステータスコードかつJSONでないレスポンスを返した際に何もエラーが表示されないようになっていました。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #10680 (b8329ac) into develop (87ff004) will decrease coverage by 2.27%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #10680      +/-   ##
===========================================
- Coverage    78.37%   76.10%   -2.27%     
===========================================
  Files          165      900     +735     
  Lines        20565    88881   +68316     
  Branches       368     6257    +5889     
===========================================
+ Hits         16118    67645   +51527     
- Misses        4447    21236   +16789     
Impacted Files Coverage Δ
packages/frontend/src/scripts/upload.ts 18.18% <0.00%> (-0.80%) ⬇️

... and 735 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@syuilo syuilo merged commit 5ddffa7 into misskey-dev:develop Apr 22, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Apr 22, 2023

👍🏻 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"File too large" error formatted incorrectly
2 participants