Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アカウント初期設定ウィザードに戻るボタンと、後で進むボタンを追加 #10893

Merged
merged 5 commits into from
May 26, 2023

Conversation

noridev
Copy link
Contributor

@noridev noridev commented May 25, 2023

What

アカウント初期設定ウィザードに戻るボタンと、後で進むボタンを追加します。

Screenshot 2023-05-25 at 14 03 01 Screenshot 2023-05-25 at 14 03 08 Screenshot 2023-05-25 at 14 03 15

Why

#10892

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #10893 (03101ba) into develop (4129ac1) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #10893      +/-   ##
===========================================
+ Coverage    77.25%   77.27%   +0.01%     
===========================================
  Files          740      740              
  Lines        70372    70372              
  Branches      6402     6408       +6     
===========================================
+ Hits         54369    54383      +14     
+ Misses       16003    15989      -14     

see 1 file with indirect coverage changes

@syuilo
Copy link
Member

syuilo commented May 26, 2023

LGTM
ちなみにスクショで使われているテーマって何ですか?

@noridev
Copy link
Contributor Author

noridev commented May 26, 2023

LGTM ちなみにスクショで使われているテーマって何ですか?

MisskeyのフォークであるCherryPickのメインとして使われているテーマです。

@syuilo syuilo merged commit cf46816 into misskey-dev:develop May 26, 2023
@syuilo
Copy link
Member

syuilo commented May 26, 2023

👍🏻

1 similar comment
@syuilo
Copy link
Member

syuilo commented May 26, 2023

👍🏻

sasagar pushed a commit to sasagar/misskey that referenced this pull request Jun 5, 2023
* enhance(frontend): アカウント初期設定ウィザードに戻るボタンを追加

* enhance(frontend): アカウント初期設定ウィザードにあとでボタンを追加

* tweak

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend:test packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants