-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): use system-ui for system font #11177
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #11177 +/- ##
===========================================
+ Coverage 77.70% 77.85% +0.14%
===========================================
Files 908 910 +2
Lines 91750 91909 +159
Branches 7670 7697 +27
===========================================
+ Hits 71295 71555 +260
+ Misses 20455 20354 -101 |
4ce4048
to
88709fa
Compare
This was originally set to Hiragino Maru Gothic Pro, which is the same as the current default font.
簡単ですのでマージしました👍 |
@fireattack May I have your opinion about this changes? |
It looks to me this change is under the switch "Use the system's default font", so I think it's totally fine since user can choose to not use it. Below are just comments about In general using Because on Chinese and Japanese Windows, it would end up using Microsoft Yahei and Yu Gothic UI fonts, respectively. The former isn't optimized to show non-Chinese content (its Japanese glyphs are especially ugly), while the latter isn't even suitable to display Japanese content: as the name suggests, it's intended to be a "UI" font - it's very narrow to accommodate long Japanese words in UI elements such as context menu, button etc. You're supposed to use "Yu Gothic" to show normal text in Japanese. This is very different from MacOS or some Linux desktop OS where the default system font is also supposed to be used to display normal text. And because these two fonts are unicode, it won't fallback to other fonts either. English Windows does not suffer from this issue the other way precisely because its default UI font, "Segoe UI", not only is great to show English characters, it also does not contain any CJK glyphs so these would fallback to other "proper" fonts. |
* fix(frontend): correct system font stack This was originally set to Hiragino Maru Gothic Pro, which is the same as the current default font. * just use system-ui per code review misskey-dev#11177 (comment) --------- Co-authored-by: Kagami Sascha Rosylight <saschanaz@outlook.com>
What
Fix
font-family
value applied by system font setting.Why
This was originally set to Hiragino Maru Gothic Pro, which is the same as the current default font.
Therefore, no visible effect would be seen.
This PR changes the font-family value for system font setting to
system-ui
, which has support from all modern browser versions: https://caniuse.com/font-family-system-ui(The initial PR of this version used this font stack, however was simplified to just
system-ui
as we don't need to care about older browser versions per code review #11177 (comment))Additional info (optional)
Checklist