Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Change isPublic to correctly recognize as:Public term #11347

Merged
merged 3 commits into from Jul 25, 2023

Conversation

hakatashi
Copy link
Contributor

What

ActivityPub経由で投稿されたNoteがpublicであるかどうかを as#Public ではなく as:Public で識別するように修正

Why

ActivityPub経由で受信したNoteがpublicであるかの判定の1つに as#Public とありますが、これは as:Public の間違いであると思われます。

NOTE
Compacting an ActivityStreams object using the ActivityStreams JSON-LD context might result in https://www.w3.org/ns/activitystreams#Public being represented as simply Public or as:Public which are valid representations of the Public collection. Implementations which treat ActivityStreams objects as simply JSON rather than converting an incoming activity over to a local context using JSON-LD tooling should be aware of this and should be prepared to accept all three representations.
5.6 Public Addressing - ActivityPub

これに起因して、外部サーバーから as:Public で投稿されたパブリックな投稿がタイムラインに表示されない不具合が存在しますが、この変更によって修正されます。

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
    • No change to UI
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jul 22, 2023
@github-actions github-actions bot requested review from syuilo and tamaina July 22, 2023 08:24
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #11347 (2444eeb) into develop (c1a19ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #11347   +/-   ##
========================================
  Coverage    77.69%   77.69%           
========================================
  Files          173      173           
  Lines        21599    21599           
  Branches       498      498           
========================================
  Hits         16782    16782           
  Misses        4817     4817           

@acid-chicken acid-chicken merged commit 0404d9c into misskey-dev:develop Jul 25, 2023
17 of 18 checks passed
@hakatashi hakatashi deleted the patch-1 branch July 25, 2023 13:45
@tai-cha tai-cha mentioned this pull request Jul 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants