redisForTimelineに入っていない古い投稿を見れるようにする #11976
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11976 +/- ##
===========================================
- Coverage 79.22% 78.80% -0.42%
===========================================
Files 930 177 -753
Lines 99529 23215 -76314
Branches 8051 510 -7541
===========================================
- Hits 78848 18295 -60553
+ Misses 20681 4920 -15761 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Oct 6, 2023
| @@ -874,7 +874,7 @@ export class NoteCreateService implements OnApplicationShutdown { | |||
| }); | |||
|
|
|||
| // TODO: あまりにも数が多いと redisPipeline.exec に失敗する(理由は不明)ため、3万件程度を目安に分割して実行するようにする | |||
| for (const following of followings) { | |||
| for (const following of [...followings, note.userId]) { | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#11958
redisForTimelineに入っていない古い投稿を見れるようにする Get older posts not stored in redisForTimeline
Why
Additional info (optional)
・とりあえずホームタイムラインのみ実装
・タイムラインを200件以上さかのぼった場合、DBにアクセスしノートが取得できることを確認した
Checklist