-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: アカウント登録時のメールアドレス認証に30分の有効期限を設定 #12221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12221 +/- ##
===========================================
+ Coverage 78.94% 79.09% +0.15%
===========================================
Files 176 178 +2
Lines 23009 23179 +170
Branches 493 493
===========================================
+ Hits 18164 18334 +170
Misses 4845 4845 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -71,6 +71,11 @@
"optional": false,
"nullable": false
},
+ "emailVerificationExpiresIn": {
+ "type": "number",
+ "optional": false,
+ "nullable": false
+ },
"enableHcaptcha": {
"type": "boolean",
"optional": false,
@@ -423,6 +428,7 @@
"cacheRemoteFiles",
"cacheRemoteSensitiveFiles",
"emailRequiredForSignup",
+ "emailVerificationExpiresIn",
"enableHcaptcha",
"hcaptchaSiteKey",
"enableRecaptcha",
@@ -11189,6 +11195,10 @@
"emailRequiredForSignup": {
"type": "boolean"
},
+ "emailVerificationExpiresIn": {
+ "type": "integer",
+ "minimum": 0
+ },
"enableHcaptcha": {
"type": "boolean"
},
@@ -37646,6 +37656,11 @@
"optional": false,
"nullable": false
},
+ "emailVerificationExpiresIn": {
+ "type": "number",
+ "optional": false,
+ "nullable": false
+ },
"enableHcaptcha": {
"type": "boolean",
"optional": false,
@@ -37864,6 +37879,7 @@
"cacheRemoteFiles",
"cacheRemoteSensitiveFiles",
"emailRequiredForSignup",
+ "emailVerificationExpiresIn",
"enableHcaptcha",
"hcaptchaSiteKey",
"enableRecaptcha", |
syuilo
reviewed
Nov 2, 2023
有効期間を設けたくないケースってなさそうだし30分とかで決め打ちしちゃってもいい気がしてきた |
30分で固定してみました:eyes: |
👍🏻 👍🏻 👍🏻 |
hideki0403
added a commit
to hideki0403/kakurega.app
that referenced
this pull request
Nov 3, 2023
* add: metaにemailVerificationExpiresInを追加 * enhance: 招待コード使用時, メアド認証時に認証期限を確認するように * add: クライアント側に実装 * update: CHANGELOG.md * add: コメントを追加 * Revert "add: metaにemailVerificationExpiresInを追加" This reverts commit ceb6ccf. * Revert "add: コメントを追加" This reverts commit 7ee301c. * change(client): メール認証の有効期限を30分で固定するように変更 * change(backend): メール認証の有効期限を30分で固定するように変更 * update: CHANGELOG.md
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 9, 2023
* add: metaにemailVerificationExpiresInを追加 * enhance: 招待コード使用時, メアド認証時に認証期限を確認するように * add: クライアント側に実装 * update: CHANGELOG.md * add: コメントを追加 * Revert "add: metaにemailVerificationExpiresInを追加" This reverts commit ceb6ccf. * Revert "add: コメントを追加" This reverts commit 7ee301c. * change(client): メール認証の有効期限を30分で固定するように変更 * change(backend): メール認証の有効期限を30分で固定するように変更 * update: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
アカウント登録時のメールアドレス認証に30分の有効期限を設定しました。
有効期限が切れた後であれば、登録時に使用した招待コードを再度利用できるように変更しました。
Why
ユーザーが誤ったメールアドレスを入力した場合に招待コードが失効してしまう問題が存在するため
Additional info (optional)
Checklist