Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: アカウント登録時のメールアドレス認証に30分の有効期限を設定 #12221

Merged
merged 12 commits into from
Nov 3, 2023

Conversation

hideki0403
Copy link
Contributor

@hideki0403 hideki0403 commented Nov 2, 2023

What

アカウント登録時のメールアドレス認証に30分の有効期限を設定しました。
有効期限が切れた後であれば、登録時に使用した招待コードを再度利用できるように変更しました。

Why

ユーザーが誤ったメールアドレスを入力した場合に招待コードが失効してしまう問題が存在するため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82526ad) 78.94% compared to head (8d8611e) 79.09%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12221      +/-   ##
===========================================
+ Coverage    78.94%   79.09%   +0.15%     
===========================================
  Files          176      178       +2     
  Lines        23009    23179     +170     
  Branches       493      493              
===========================================
+ Hits         18164    18334     +170     
  Misses        4845     4845              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 2, 2023

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -71,6 +71,11 @@
                       "optional": false,
                       "nullable": false
                     },
+                    "emailVerificationExpiresIn": {
+                      "type": "number",
+                      "optional": false,
+                      "nullable": false
+                    },
                     "enableHcaptcha": {
                       "type": "boolean",
                       "optional": false,
@@ -423,6 +428,7 @@
                     "cacheRemoteFiles",
                     "cacheRemoteSensitiveFiles",
                     "emailRequiredForSignup",
+                    "emailVerificationExpiresIn",
                     "enableHcaptcha",
                     "hcaptchaSiteKey",
                     "enableRecaptcha",
@@ -11189,6 +11195,10 @@
                   "emailRequiredForSignup": {
                     "type": "boolean"
                   },
+                  "emailVerificationExpiresIn": {
+                    "type": "integer",
+                    "minimum": 0
+                  },
                   "enableHcaptcha": {
                     "type": "boolean"
                   },
@@ -37646,6 +37656,11 @@
                       "optional": false,
                       "nullable": false
                     },
+                    "emailVerificationExpiresIn": {
+                      "type": "number",
+                      "optional": false,
+                      "nullable": false
+                    },
                     "enableHcaptcha": {
                       "type": "boolean",
                       "optional": false,
@@ -37864,6 +37879,7 @@
                     "cacheRemoteFiles",
                     "cacheRemoteSensitiveFiles",
                     "emailRequiredForSignup",
+                    "emailVerificationExpiresIn",
                     "enableHcaptcha",
                     "hcaptchaSiteKey",
                     "enableRecaptcha",

Get diff files from Workflow Page

@syuilo
Copy link
Member

syuilo commented Nov 3, 2023

有効期間を設けたくないケースってなさそうだし30分とかで決め打ちしちゃってもいい気がしてきた

@hideki0403 hideki0403 changed the title enhance: 登録時のメール認証に有効期限を設定できるように enhance: アカウント登録時のメールアドレス認証に30分の有効期限を設定 Nov 3, 2023
@hideki0403
Copy link
Contributor Author

30分で固定してみました:eyes:

@syuilo syuilo merged commit 025ae43 into misskey-dev:develop Nov 3, 2023
17 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 3, 2023

👍🏻 👍🏻 👍🏻

@hideki0403 hideki0403 deleted the enhance-mail-auth branch November 3, 2023 05:54
hideki0403 added a commit to hideki0403/kakurega.app that referenced this pull request Nov 3, 2023
* add: metaにemailVerificationExpiresInを追加

* enhance: 招待コード使用時, メアド認証時に認証期限を確認するように

* add: クライアント側に実装

* update: CHANGELOG.md

* add: コメントを追加

* Revert "add: metaにemailVerificationExpiresInを追加"

This reverts commit ceb6ccf.

* Revert "add: コメントを追加"

This reverts commit 7ee301c.

* change(client): メール認証の有効期限を30分で固定するように変更

* change(backend): メール認証の有効期限を30分で固定するように変更

* update: CHANGELOG.md
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
* add: metaにemailVerificationExpiresInを追加

* enhance: 招待コード使用時, メアド認証時に認証期限を確認するように

* add: クライアント側に実装

* update: CHANGELOG.md

* add: コメントを追加

* Revert "add: metaにemailVerificationExpiresInを追加"

This reverts commit ceb6ccf.

* Revert "add: コメントを追加"

This reverts commit 7ee301c.

* change(client): メール認証の有効期限を30分で固定するように変更

* change(backend): メール認証の有効期限を30分で固定するように変更

* update: CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants