Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): remove reactions fully on account deletion #12249

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Mar0xy
Copy link
Contributor

@Mar0xy Mar0xy commented Nov 5, 2023

What

This PR will make sure to remove reactions fully when someone deletes their account.

Why

Fixes #11906

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 5, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (780b120) 78.72% compared to head (baf162c) 78.68%.

Files Patch % Lines
.../queue/processors/DeleteAccountProcessorService.ts 18.42% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12249      +/-   ##
===========================================
- Coverage    78.72%   78.68%   -0.04%     
===========================================
  Files          951      950       -1     
  Lines       103311   103284      -27     
  Branches      8301     8303       +2     
===========================================
- Hits         81332    81274      -58     
- Misses       21979    22010      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 5, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@Mar0xy
Copy link
Contributor Author

Mar0xy commented Nov 26, 2023

Bug is still valid as of latest version.

@Mar0xy
Copy link
Contributor Author

Mar0xy commented Dec 2, 2023

@kakkokari-gtyih Is the code okay like this or should something be changed?

Also I noticed in the recent blog post about misskey's 2023 year there was a mention of trying to become GDPR compliant next year and we(Sharkey) have a GDPR related feature for letting users get all their stored data and I wonder if there is any interest in having it merged.
https://github.com/transfem-org/Sharkey/blob/develop/packages/backend/src/queue/processors/ExportAccountDataProcessorService.ts

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Dec 2, 2023

I am not an expert on the backend so I cannot determine this, so let me ask @syuilo about these instead.

@kakkokari-gtyih

This comment was marked as off-topic.

@kakkokari-gtyih
Copy link
Contributor

@syuilo 👀👀👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactions from deleted users stay on posts
2 participants