-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: コントロールパネルのアイコンデコレーションページから直接ファイルをアップロードおよび設定できるように #12387
Open
hideki0403
wants to merge
9
commits into
misskey-dev:develop
Choose a base branch
from
hideki0403:feat-decoration-url-from-drive
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enhance: コントロールパネルのアイコンデコレーションページから直接ファイルをアップロードおよび設定できるように #12387
hideki0403
wants to merge
9
commits into
misskey-dev:develop
from
hideki0403:feat-decoration-url-from-drive
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12387 +/- ##
===========================================
- Coverage 78.74% 78.63% -0.12%
===========================================
Files 950 950
Lines 103308 103308
Branches 8356 8329 -27
===========================================
- Hits 81354 81240 -114
- Misses 21954 22068 +114 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 差分はこちら |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
コントロールパネルの「アイコンデコレーション」ページ内にあるデコレーション設定項目の部分に「ファイルを選択」ボタンを追加し、直接ファイルをアップロード(またはドライブから選択)することができるようにしました。
また、ファイル選択時にデコレーション名および画像URLが設定されるようにしました。
Why
現状、アバターデコレーションを追加するには手動でファイルをドライブにアップロードし、画像URL等をコピペする必要があり、不便なため
Additional info (optional)
Checklist