feat(frontend): リアクションの横幅を150pxに制限するかどうかユーザーが選べるように #12416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkokari-gtyih
approved these changes
Nov 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12416 +/- ##
===========================================
- Coverage 78.78% 78.73% -0.05%
===========================================
Files 945 947 +2
Lines 102164 102897 +733
Branches 8262 8289 +27
===========================================
+ Hits 80488 81020 +532
- Misses 21676 21877 +201 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
approved these changes
Nov 23, 2023
ご指摘ありがとうございます。修正いたしました 🙏 |
syuilo
reviewed
Nov 23, 2023
| @@ -11,7 +11,7 @@ SPDX-License-Identifier: AGPL-3.0-only | |||
| :class="[$style.root, { [$style.reacted]: note.myReaction == reaction, [$style.canToggle]: canToggle, [$style.small]: defaultStore.state.reactionsDisplaySize === 'small', [$style.large]: defaultStore.state.reactionsDisplaySize === 'large' }]" | |||
| @click="toggleReaction()" | |||
| > | |||
| <MkReactionIcon :class="$style.icon" :reaction="reaction" :emojiUrl="note.reactionEmojis[reaction.substring(1, reaction.length - 1)]"/> | |||
| <MkReactionIcon :class="defaultStore.state.limitWidthOfReaction ? $style.icon : ''" :reaction="reaction" :emojiUrl="note.reactionEmojis[reaction.substring(1, reaction.length - 1)]"/> | |||
There was a problem hiding this comment.
クラス名を limitWidth とかに変えた方がわかりやすそう
There was a problem hiding this comment.
元々の実装を使いましたが、変えてよければ変えてしまいますね！
|
👍 |
anatawa12
pushed a commit
to anatawa12/misskey
that referenced
this pull request
Nov 27, 2023
* feat(frontend): リアクションの横幅を150pxに制限するかどうかユーザーが選べるように * localesの変更をjs-JP.ymlのみに修正し、日本語をより分かりやすく * クラス名を.icon から .limitWidthに変更
anatawa12
added a commit
to anatawa12/misskey
that referenced
this pull request
Nov 27, 2023
|
CHANGELKOG要りそう |
camilla-ett
added a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* feat(frontend): リアクションの横幅を150pxに制限するかどうかユーザーが選べるように * localesの変更をjs-JP.ymlのみに修正し、日本語をより分かりやすく * クラス名を.icon から .limitWidthに変更
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
いつぞやのタイミングで、リアクションの横幅が150pxに制限されるようになりましたが、
ユーザーの設定画面で、横幅を制限して縮小させるか、縮小せずにそのまま表示するかを選べるようにしました。
Why
従来通りの見た目が良いというユーザーが一定数存在するため
Additional info (optional)
https://kasei.ski/notes/9mebe4h6ba 動作の様子
https://dev.kasei.ski/ にて動作確認できます
Checklist