Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): コードエディタが正しく表示されない問題を修正 #12418

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

コードエディタが正しく表示されない問題を修正(元issueのカスタムCSSを一部適用)

Why

Fix #12398

Additional info (optional)

とりあえず Firefox 116.0.2 (64 ビット) で動作することを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed6f866) 78.63% compared to head (aa87aa3) 78.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12418      +/-   ##
===========================================
+ Coverage    78.63%   78.78%   +0.15%     
===========================================
  Files          176      178       +2     
  Lines        23358    23528     +170     
  Branches       496      496              
===========================================
+ Hits         18367    18537     +170     
  Misses        4991     4991              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit cba66c9 into misskey-dev:develop Nov 23, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 23, 2023

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-12398 branch November 23, 2023 12:55
u1-liquid pushed a commit to u1-liquid/misskey that referenced this pull request Nov 25, 2023
* (fix) コードエディタが正しく表示されない問題を修正

* Update Changelog
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* (fix) コードエディタが正しく表示されない問題を修正

* Update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

スクラッチパッドが正しく表示されない Scratchpad doesn't render correctly
2 participants