feat(frontend): 今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加 #12450

kakkokari-gtyih · 2023-11-25T09:40:40Z

What

API users/following で誕生日ごとにユーザーを絞り込めるように
今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加

Why

Fix #12192

Additional info (optional)

セキュリティ面・パフォーマンス面が心配（とりあえず動く）

Checklist

Read the contribution guide
Test working in a local environment
(If needed) Add story of storybook
(If needed) Update CHANGELOG.md
(If possible) Add tests

codecov · 2023-11-25T09:41:45Z

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (780b120) 78.72% compared to head (934e55f) 78.69%.

Files	Patch %	Lines
...ackend/src/server/api/endpoints/users/following.ts	47.82%	12 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12450      +/-   ##
===========================================
- Coverage    78.72%   78.69%   -0.04%     
===========================================
  Files          951      950       -1     
  Lines       103311   103208     -103     
  Branches      8301     8303       +2     
===========================================
- Hits         81332    81217     -115     
- Misses       21979    21991      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-11-25T09:42:25Z

このPRによるapi.jsonの差分

差分はこちら

--- base
+++ head
@@ -56888,6 +56888,10 @@
                     "type": "string",
                     "nullable": true,
                     "description": "The local host is represented with `null`."
+                  },
+                  "birthday": {
+                    "type": "string",
+                    "nullable": true
                   }
                 },
                 "anyOf": [
@@ -56950,6 +56954,15 @@
                       }
                     }
                   },
+                  "BIRTHDAY_DATE_FORMAT_INVALID": {
+                    "value": {
+                      "error": {
+                        "message": "Birthday date format is invalid.",
+                        "code": "BIRTHDAY_DATE_FORMAT_INVALID",
+                        "id": "a2b007b9-4782-4eba-abd3-93b05ed4130d"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

kakkokari-gtyih · 2023-11-25T09:45:33Z

packages/backend/migration/1700902349231-add-bday-index.js

indexがないと重くなるらしいのでindexを立てたけどコレでいいのかわからん

kakkokari-gtyih · 2023-11-25T09:52:15Z

packages/backend/src/server/api/endpoints/users/following.ts

+					const birthday = `____-${(d.getMonth() + 1).toString().padStart(2, '0')}-${d.getDate().toString().padStart(2, '0')}`;
+					const birthdayUserQuery = this.userProfilesRepository.createQueryBuilder('user_profile');
+					birthdayUserQuery.select('user_profile.userId')
+						.where(`user_profile.birthday LIKE '${birthday}'`);


怖め（typeormのパラメータがなぜか使えなかったので直接SQLに突っ込んだ）

[ask]
why LIKE文？ equal operator は =
特に理由がなければ完全一致のほうが望ましい

データベースには誕生日(MM-DD)ではなく生年月日(YYYY-MM-DD)が入るから完全一致では検索できない

あー、なるほど。

https://use-the-index-luke.com/ja/sql/where-clause/searching-for-ranges/like-performance-tuning
曰く、 LIKE分は前方にワイルドカードがくると一切インデックスが効かないらしい

ハックな方法では逆順に検索することで後方一致を前方一致に読み替えてインデックスを読み取る方法があるとか
https://blog.aleajactaest.org/article_7ehymh5nwnbkrg347nqmd33pfu.html

YYYY-MM-DDではなくMM-DDを保存するカラム新たに作っても良さそうだけどマイグレが面倒そう

ハックというか SUBSTR("birthday", 6, 5) でインデックスすればいいのでは

よさそう

なおしましたどうでしょう

syuilo · 2023-11-26T04:27:38Z

マイグレーションは作成されてるけどmodel定義の方にはインデックス設定が無いように見えるわね

fruitriin · 2023-11-26T04:30:25Z

packages/frontend/src/widgets/WidgetBirthdayFollowings.vue

+useInterval(fetch, 1000 * 60, {
+	immediate: true,
+	afterMounted: true,
+});


誕生日は1日に1回しか変わらないので60秒おきにfetchする理由はなさそう
タイムゾーンを考慮しても少なくとも1時間おきでよいのでは（半日とか1日おきでもよさそう。それか日付の変わり目に setTimeoutかな）
オンライン数分リクエストが飛ぶことを考えるとioでは7000リクエストぐらい一気にきそう

これ日付変わるのを検知しないと実際にはfetchしないようになっています

… into feat-12192

kakkokari-gtyih · 2023-11-26T05:40:18Z

マイグレーションは作成されてるけどmodel定義の方にはインデックス設定が無いように見えるわね

やった

syuilo · 2023-11-30T05:49:29Z

👍👍

acid-chicken · 2023-12-19T12:52:19Z

packages/frontend/src/widgets/WidgetBirthdayFollowings.vue

+	now.setHours(0, 0, 0, 0);
+
+	if (now > lfAtD) {
+		os.api('users/following', {
+			limit: 18,
+			birthday: now.toISOString(),


これタイムゾーン吹き飛ぶせいで UTC 以外（e.g. JST）だと一日ズレる

* (add) 今日誕生日のフォロイー一覧表示 * Update Changelog * Update Changelog * 実装漏れ * create index * (fix) index

kakkokari-gtyih added 2 commits November 25, 2023 18:35

(add) 今日誕生日のフォロイー一覧表示

53051b9

Update Changelog

d97f9a1

github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Nov 25, 2023

Update Changelog

97fc5f3

実装漏れ

5af3785

kakkokari-gtyih commented Nov 25, 2023

View reviewed changes

Merge branch 'develop' into feat-12192

684c8d9

This comment was marked as off-topic.

Sign in to view

fruitriin reviewed Nov 26, 2023

View reviewed changes

kakkokari-gtyih and others added 3 commits November 26, 2023 14:39

create index

43b08be

Merge branch 'feat-12192' of https://github.com/kakkokari-gtyih/misskey…

22ae48c

… into feat-12192

Merge branch 'develop' into feat-12192

b0ec255

kakkokari-gtyih and others added 2 commits November 26, 2023 16:43

(fix) index

f79f1a5

Merge branch 'develop' into feat-12192

934e55f

syuilo merged commit b05d71f into misskey-dev:develop Nov 30, 2023
18 checks passed

kakkokari-gtyih deleted the feat-12192 branch December 8, 2023 06:35

acid-chicken reviewed Dec 19, 2023

View reviewed changes

kakkokari-gtyih mentioned this pull request Dec 28, 2023

fix(frontend): 「今日誕生日のフォロー中ユーザー」ウィジェットが正しく動作しない問題を修正 #12835

Merged

5 tasks

acid-chicken mentioned this pull request Dec 31, 2023

日付が変わってリロードしても「今日誕生日のユーザー」ウィジェットの内容が変わらない #12869

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(frontend): 今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加 #12450

feat(frontend): 今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加 #12450

kakkokari-gtyih commented Nov 25, 2023 •

edited

Loading

codecov bot commented Nov 25, 2023 •

edited

Loading

github-actions bot commented Nov 25, 2023 •

edited

Loading

kakkokari-gtyih Nov 25, 2023

kakkokari-gtyih Nov 25, 2023 •

edited

Loading

fruitriin Nov 26, 2023

syuilo Nov 26, 2023

fruitriin Nov 26, 2023

syuilo Nov 26, 2023

acid-chicken Nov 26, 2023

fruitriin Nov 26, 2023

kakkokari-gtyih Nov 26, 2023

syuilo commented Nov 26, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

fruitriin Nov 26, 2023

kakkokari-gtyih Nov 26, 2023

kakkokari-gtyih commented Nov 26, 2023

syuilo commented Nov 30, 2023

acid-chicken Dec 19, 2023

feat(frontend): 今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加 #12450

feat(frontend): 今日誕生日のフォロー中のユーザーを一覧表示できるウィジェットを追加 #12450

Conversation

kakkokari-gtyih commented Nov 25, 2023 • edited Loading

What

Why

Additional info (optional)

Checklist

codecov bot commented Nov 25, 2023 • edited Loading

Codecov Report

github-actions bot commented Nov 25, 2023 • edited Loading

Choose a reason for hiding this comment

kakkokari-gtyih Nov 25, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syuilo commented Nov 26, 2023

This comment was marked as off-topic.

This comment was marked as off-topic.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kakkokari-gtyih commented Nov 26, 2023

syuilo commented Nov 30, 2023

Choose a reason for hiding this comment

kakkokari-gtyih commented Nov 25, 2023 •

edited

Loading

codecov bot commented Nov 25, 2023 •

edited

Loading

github-actions bot commented Nov 25, 2023 •

edited

Loading

kakkokari-gtyih Nov 25, 2023 •

edited

Loading