Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): withChannelNotesとwithFilesを同時に指定したときの考慮 #12550

Merged

Conversation

shiosyakeyakini-info
Copy link
Contributor

@shiosyakeyakini-info shiosyakeyakini-info commented Dec 3, 2023

What

#12549 を修正

Why

Redisから取得した場合とPostgreSQLから取得した場合で結果を同一にするため、またサードパーティでチャンネルのノートを含むファイルつきノートを取得できるようにするため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 3, 2023
@shiosyakeyakini-info shiosyakeyakini-info changed the title fix: withChannelNotesとwithFilesを同時に指定したときの考慮 fix(backend): withChannelNotesとwithFilesを同時に指定したときの考慮 Dec 3, 2023
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3364162) 78.73% compared to head (82207f5) 78.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12550      +/-   ##
===========================================
- Coverage    78.73%   78.39%   -0.35%     
===========================================
  Files          952      180     -772     
  Lines       103602    23824   -79778     
  Branches      8328      495    -7833     
===========================================
- Hits         81573    18676   -62897     
+ Misses       22029     5148   -16881     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@syuilo syuilo merged commit 4de4a2e into misskey-dev:develop Dec 3, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 3, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants