fix (backend): 「みつける」のなかにミュートしたユーザが現れてしまう問題を修正 #12559
Merged
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12559 +/- ##
===========================================
+ Coverage 78.42% 78.77% +0.35%
===========================================
Files 180 956 +776
Lines 23857 104015 +80158
Branches 495 8351 +7856
===========================================
+ Hits 18709 81943 +63234
- Misses 5148 22072 +16924 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
syuilo
reviewed
Dec 3, 2023
| ] = me ? await Promise.all([ | ||
| this.cacheService.userMutingsCache.fetch(me.id), | ||
| this.cacheService.userBlockedCache.fetch(me.id), | ||
| ]) : [new Set<string>(), new Set<string>(), new Set<string>()]; |
There was a problem hiding this comment.
2つにしました
凡ミス申し訳ないです🙇♂️
|
🙏🙏 |
camilla-ett
pushed a commit
to kaseiski/misskey
that referenced
this pull request
Jan 2, 2024
* fix (backend): 「みつける」のなかにミュートしたユーザが現れてしまう問題を修正 * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12383 の対処です。
この対応により、自分がミュートしたユーザがハイライトの中に表示されることがなくなります。
また、同様にハイライトに載っているユーザにブロックされている場合、同じくハイライトの中に表示されることがなくなります。
Why
fix #12383
Additional info (optional)
以下をローカルで確認しました
Checklist