Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): 年越し時にトレンドが壊れる問題をエポックを固定することで修正 #12567

Merged

Conversation

anatawa12
Copy link
Member

What

Fix #12486

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18109fc) 78.76% compared to head (9dc236d) 78.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12567      +/-   ##
===========================================
- Coverage    78.76%   78.68%   -0.09%     
===========================================
  Files          955      952       -3     
  Lines       103817   103318     -499     
  Branches      8334     8269      -65     
===========================================
- Hits         81770    81292     -478     
+ Misses       22047    22026      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link
Member

@samunohito samunohito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっと気になったのでコメントさせてください 🙏

packages/backend/src/core/FeaturedService.ts Show resolved Hide resolved
@anatawa12 anatawa12 changed the title fix(backend): エポックを固定することで年越し時にトレンドが壊れる問題を修正 fix(backend): 年越し時にトレンドが壊れる問題をエポックを固定することで修正 Dec 4, 2023
@syuilo syuilo merged commit 8866c53 into misskey-dev:develop Dec 4, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 4, 2023

🙏🏻 🙏🏻

@anatawa12 anatawa12 deleted the fix-featured-broken-after-end-of-year branch March 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

featuredが年越しのタイミングで多分壊れる
3 participants