Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

リアクションの絵文字詳細ビューアでよみがなとかライセンスとか確認したい #12695

Conversation

fruitriin
Copy link
Contributor

What

スクリーンショット 2023-12-17 11 24 33

Why

他の人の使った絵文字の出し方がわからんとかありがちなので
あとライセンスやカテゴリも見れるようにしました

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67824cf) 79.65% compared to head (299477c) 79.64%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12695      +/-   ##
===========================================
- Coverage    79.65%   79.64%   -0.01%     
===========================================
  Files          955      955              
  Lines       107713   107729      +16     
  Branches      8351     8349       -2     
===========================================
+ Hits         85796    85803       +7     
- Misses       21917    21926       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fruitriin
Copy link
Contributor Author

fruitriin commented Dec 17, 2023

https://misskey.systems/ ためせます

@kakkokari-gtyih
Copy link
Contributor

いらない人はいらないと思うのでオプトインでもいいかも

@fruitriin
Copy link
Contributor Author

その辺はおまかせ

@1STEP621
Copy link
Contributor

1STEP621 commented Jan 10, 2024

個人的には、ここにいろいろな情報を出すよりは
Screenshot from 2024-01-10 14-16-05
/about#emojisで絵文字詳細を見ると出てくるこのポップアップを、リアクションを右クリック/ロングタップしたときのメニューから表示できるようにするのが良いように思う

@fruitriin fruitriin closed this Jan 12, 2024
@fruitriin
Copy link
Contributor Author

誰も触らないのでクローズしました
望む人は再開してください

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants