Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(frontend): CW内などの画像が表示されないことがあるバグを修正 #12721

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

1STEP621
Copy link
Contributor

What

画像のアスペクト比をデフォルト以外に設定していると、CW内などに添付された画像が表示されないバグを修正しました

Why

画像が表示されないと困るため
Resolve #12719

Additional info (optional)

ほとんど #11377 のRevertのようになっているため、パフォーマンス的に悪化した可能性があります...

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21882b6) 81.87% compared to head (e144cfd) 81.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12721      +/-   ##
===========================================
+ Coverage    81.87%   81.90%   +0.03%     
===========================================
  Files          180      180              
  Lines        27527    27466      -61     
  Branches       511      511              
===========================================
- Hits         22537    22496      -41     
+ Misses        4990     4970      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1STEP621
Copy link
Contributor Author

Test落ちてるの謎

@syuilo syuilo merged commit 10d4ae1 into misskey-dev:develop Dec 20, 2023
13 of 15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 20, 2023

🙏🏻

@tamaina
Copy link
Member

tamaina commented Dec 20, 2023

コードを変えてないのにcqhが効くようになったの謎

@tamaina
Copy link
Member

tamaina commented Dec 20, 2023

(container-type: inline-sizeの高さが適用されていたのがブラウザ側でsizeまで遡るように修正された?)

@1STEP621 1STEP621 deleted the fix/image-does-not-appear branch December 28, 2023 15:16
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* 画像のアスペクト比をデフォルト以外に設定しているとCW内の画像が表示されないのを修正

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CWの中に画像を添付した場合、その画像が見られないことがある
3 participants