-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance(frontend): 年齢を非表示にできるように #12821
Enhance(frontend): 年齢を非表示にできるように #12821
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #12821 +/- ##
===========================================
- Coverage 79.87% 79.87% -0.01%
===========================================
Files 956 956
Lines 109066 109050 -16
Branches 8417 8417
===========================================
- Hits 87120 87105 -15
+ Misses 21946 21945 -1 ☔ View full report in Codecov by Sentry. |
This reverts commit d42d4ed.
This comment was marked as outdated.
This comment was marked as outdated.
…/set-birth-year-to-9999-to-hide-age
…/set-birth-year-to-9999-to-hide-age
…om:1STEP621/misskey into enhance/set-birth-year-to-9999-to-hide-age
どちらにせよ元issueでマジックナンバーにすべきかどうかを含め色々検討が進んでいるのでそれを待ったほうが良さそう |
Firefox, Chromeともに、そもそもブラウザ側で0000年を入力することはできませんでした Screencast.from.2024.01.03.22.32.23.webm |
このPRによるapi.jsonの差分 差分はこちら |
元issueでもう少し議論が進んでからのほうが良さそうなので一旦closeします🙏 |
What
誕生年に9999年を指定すると、年齢を非表示にできるようにしました。
Why
Resolve #10005
Additional info (optional)
Checklist