Indicate if input value is invalid #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
パスワード強度を表示するやつを流用するのではダメですか？ |
あちこちで使われてる共用コンポーネントなのであれだと |
|
アイコン変わってるの気づかなかったので |
|
ふちどりは |
|
|
|
両方にしちゃってもいいかもしれませんね（） |
|
デフォルトテーマのフォーカス状態がこんな感じなので、下線だけだとわからない気がしたり |
|
|
> .title
white-space nowrap
width 133%
overflow hidden
text-overflow ellipsis
|
|
|
mei23
approved these changes
Sep 28, 2019
|
@syuilo やっぱり下の線も色変えた方が良いかな？ |
|
これで良さそう |
|
ありがとうございます 🙏🙏🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related #5375 (resolve?)
ui-inputは値のValidation状態を分かりづらい（Mouseホバーで出るtooltipでやっとわかる）ui-inputの値のValidationがfalseになってもv自体がエラーになるわけでもないので普通にnull扱いされる（これは仕様？）→ ユーザーにValidationがfailだということを知らせる必要がありそう
（実は
this.$refs.input.validationMessageを常に見えるtooltipとかで見せたかったがどうすればいいのかよくわかんなかったのでこれ）